Conversation
0e0f83e to
48f7ed0
Compare
f344afa to
dab8d20
Compare
2e5185a to
35ef249
Compare
7fbb182 to
08f0f8b
Compare
7e6b3a9 to
846f363
Compare
Fixes #1262 - Allow choosing of binding categories, and renaming declarations of term-like categories - Drop `_ptr` suffix from FunPtr and Global - Fixture changes (drop `_ptr`) - Fix manual (drop `_ptr`) - Do not produce golden test file when output is empty - Remove empty golden files Other changes: - (Don't use) TypeData, which is only available since GHC 9.6
e033109 to
6622876
Compare
edsko
approved these changes
Dec 18, 2025
Collaborator
edsko
left a comment
There was a problem hiding this comment.
Great, will be good to get this in :)
85f7f83 to
0449845
Compare
0449845 to
28c0c83
Compare
28c0c83 to
a7a0316
Compare
a7a0316 to
9323da1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to control binding categories in a more fine-grained manner.
In particular, we will be able to include/exclude complete binding categories,
as well as rename declarations in term-level categories (e.g., functions,
function pointers, or globals).
We will have
Defaults
useSafeCategory.preprocessmode: use all categories.Remarks
ByCategory ByCategory.Choice) in the preprocessor #1328Tasks
After meeting with Edsko:
We need to ensure that we do not rename unique symbols; we need some other changes before we can do so, and will pause this PR until then.
We want to extend the scope of the golden tests to check that we do not rename definition sites that have use sites.
The rename function needs to be discussed.
Fix Function pointer bindings should not have
_ptrsuffix #1262Golden test case for Function pointer bindings should not have
_ptrsuffix #1262 <- We want to test the category choice renaming feature!Check that empty modules are not created (@jorisdral ?) -> I think we should check this in a basic integration test (included in this PR), but handle the fixtures in a seprate task/PR.